RFR: 8300493: Use ArraysSupport.vectorizedHashCode in j.u.zip.ZipCoder [v2]
Lance Andersen
lancea at openjdk.org
Fri Jan 20 16:45:58 UTC 2023
On Fri, 20 Jan 2023 12:19:50 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> `ZipCoder::checkedHashCode` emulates `StringLatin1::hashCode` but operates on a `byte[]` subrange. It can profitably use the recently introduced `ArraysSupport::vectorizedHashCode` method to see a speed-up, which translates to a small but significant speed-up on `ZipFile` creation.
>>
>> Before:
>>
>> Benchmark (size) Mode Cnt Score Error Units
>> ZipFileOpen.openCloseZipFile 512 avgt 15 83007.325 ± 1446.716 ns/op
>> ZipFileOpen.openCloseZipFile 1024 avgt 15 154550.631 ± 2166.673 ns/op
>>
>> After:
>>
>> Benchmark (size) Mode Cnt Score Error Units
>> ZipFileOpen.openCloseZipFile 512 avgt 15 79512.902 ± 814.449 ns/op
>> ZipFileOpen.openCloseZipFile 1024 avgt 15 147892.522 ± 2744.017 ns/op
>
> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
>
> Vary dir and entry name lengths across a wider spread, keeping most entries short but making the longest paths longer
Thank you Claes
-------------
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12077
More information about the security-dev
mailing list