RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 [v2]

Rajan Halade rhalade at openjdk.org
Mon Jan 30 20:55:03 UTC 2023


On Mon, 30 Jan 2023 12:17:10 GMT, Matthew Donovan <duke at openjdk.org> wrote:

>> * updated test for new TLS protocols and ciphersuites
>> * code cleanup
>
> Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - incorporated Rajan's patch
>  - Merge branch 'master' into test-all-suites
>  - 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3

test/jdk/javax/net/ssl/SSLEngine/TestAllSuites.java line 236:

> 234:         testAllSuites.createSSLEngines();
> 235:         testAllSuites.test();
> 236:         

There are several `trailing whitespace` errors, please fix.

test/lib/jdk/test/lib/security/SecurityUtils.java line 65:

> 63:     }
> 64:     
> 65:     public static void addToDisabledTlsAlgs(String... protocols) {

Move these to line 55 (before removeFromDisabledTlsAlgs method) so remove and add methods stay together.

test/lib/jdk/test/lib/security/SecurityUtils.java line 69:

> 67:     }
> 68:     
> 69:     public static void addToDisabledArgs(String prop, List<String> constraints) {

Add the comment for method like "remove..." methods.

-------------

PR: https://git.openjdk.org/jdk/pull/11780



More information about the security-dev mailing list