RFR: 8311170: Simplify and modernize equals and hashCode in security area [v4]

Roger Riggs rriggs at openjdk.org
Wed Jul 5 21:14:55 UTC 2023


On Wed, 5 Jul 2023 20:52:56 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Are you sure? I just checked lines 91-92 and I'd say the change looks correct.
>
>> The original `<=` was correct, the number of bits in the input array must be less than the requested length of the BitArray. The constructors also describe the length using `<=`; they all should be consistent.
> 
> Hm... My reading is that those "i.e." parts state preconditions for the constructors to return successfully, not preconditions for them to throw an exception.

I stand corrected.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14738#discussion_r1253655028



More information about the security-dev mailing list