RFR: 8295068: SSLEngine throws NPE parsing CertificateRequests [v2]

Xue-Lei Andrew Fan xuelei at openjdk.org
Thu Jul 6 16:25:59 UTC 2023


On Thu, 6 Jul 2023 15:52:00 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> JDK-8295068: an NPE is thrown when an invalid `id` is found to match up a `ClientCertificateType`; rather than throwing the `NPE`, we now ignore an `id` which does match a `ClientCertificateType`.
>
> Kevin Driver has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - remove extra line break
>  - fail to look up the id silently to not throw an unexpected error

It looks good to me.  Thank you for the update.

-------------

Marked as reviewed by xuelei (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14778#pullrequestreview-1516909264



More information about the security-dev mailing list