RFR: 8311170: Simplify and modernize equals and hashCode in security area [v4]

[Sean Mullan]

On Wed, 5 Jul 2023 18:18:02 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8311170
>>  - Be consistent with the rest of the change
>>  - Fix reported bugs
>>  - Add even more cases and tidy up
>>  - More cases
>>  - Initial commit
>
> src/java.base/share/classes/sun/security/x509/X500Name.java line 422:
> 
>> 420:         // quick check that number of RDNs and AVAs match before canonicalizing
>> 421:         if (!Arrays.equals(this.names, other.names,
>> 422:                 Comparator.comparingInt(n -> n.assertion.length)))
> 
> I'd keep the original comparison of the lengths; its a lot less magical than `Comparator.comparingInt(n -> n.assertion.length))`

I tend to agree with Roger. I have to think more about what is being compared with the new code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14738#discussion_r1254706673