RFR: 8311170: Simplify and modernize equals and hashCode in security area [v4]
Sean Mullan
mullan at openjdk.org
Thu Jul 6 17:35:57 UTC 2023
On Wed, 5 Jul 2023 17:53:55 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Merge branch 'master' into 8311170
>> - Be consistent with the rest of the change
>> - Fix reported bugs
>> - Add even more cases and tidy up
>> - More cases
>> - Initial commit
>
> src/java.base/share/classes/java/security/cert/X509CRLEntry.java line 110:
>
>> 108: public int hashCode() {
>> 109: try {
>> 110: return Arrays.hashCode(this.getEncoded());
>
> What data is at `entryData[0]` that will now be included in the hashCode when it was skipped before?
I would have to dump out an encoded CRL to check, but I think it should be ok to include it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14738#discussion_r1254732666
More information about the security-dev
mailing list