RFR: 8281658: Add a security category to the java -XshowSettings option [v8]
Sean Coffey
coffeys at openjdk.org
Fri Jul 7 13:47:35 UTC 2023
On Thu, 6 Jul 2023 14:03:12 GMT, Sean Mullan <mullan at openjdk.org> wrote:
>> Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
>>
>> - Avoid sharing INDENT variables
>> - Merge branch 'master' into 8281658-showsettings-security
>> - Don't allow bad subcommand values for security component
>> - restore more informative help message
>> - Split long properties for ; also
>> - Pass PrintStream to security helper
>> - Refactor out security code to helper class
>> - Print aliases. Order Provider type/service output.
>> - Incorporate review comments from Roger and tweak some code
>> - Merge branch 'master' into 8281658-showsettings-security
>> - ... and 5 more: https://git.openjdk.org/jdk/compare/774eb316...7e6f5090
>
> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 123:
>
>> 121: }
>> 122:
>> 123: ostream.println(INDENT + "Security TLS configuration:");
>
> What about also noting the name of the TLS/JSSE provider in this line, for example:
>
> "Security TLS configuration (SunJSSE provider):"
>
> This would be useful information if a customer is using a 3rd party JSSE provider, and it is selected before SunJSSE, as the defaults in that case may be different.
good suggestion Sean. Patch updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1255842787
More information about the security-dev
mailing list