RFR: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform [v2]

Justin Lu jlu at openjdk.org
Thu Jul 13 18:07:54 UTC 2023


> Please review this PR which addresses `KeytoolReaderP12Test.java` failing for non-English locale users.
> 
> This test checks output from keytool, but fails on finding the value 'alias name' for non-English locale users. This is because 'alias name' is a localized value. (For example, in `ja` this is '別名'). 
> 
> To fix the failing issue, the keytool process should be ran with `-J-Duser.language=en -J-Duser.country=US`.

Justin Lu has updated the pull request incrementally with two additional commits since the last revision:

 - Revert spacing changes to KeytoolReaderP12Test.java
 - Move English locale params to executeKeytoolCommand

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14806/files
  - new: https://git.openjdk.org/jdk/pull/14806/files/57765c77..452a603d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14806&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14806&range=00-01

  Stats: 18 lines in 2 files changed: 3 ins; 4 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/14806.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14806/head:pull/14806

PR: https://git.openjdk.org/jdk/pull/14806



More information about the security-dev mailing list