RFR: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform

Justin Lu jlu at openjdk.org
Thu Jul 13 18:08:23 UTC 2023


On Fri, 7 Jul 2023 18:58:02 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which addresses `KeytoolReaderP12Test.java` failing for non-English locale users.
> 
> This test checks output from keytool, but fails on finding the value 'alias name' for non-English locale users. This is because 'alias name' is a localized value. (For example, in `ja` this is '別名'). 
> 
> To fix the failing issue, the keytool process should be ran with `-J-Duser.language=en -J-Duser.country=US`.

I have updated the fix so that `executeKeytoolCommand()` itself always sets the English locale params, as `executeKeytoolCommand()` is not used in any sort of intentional localized testing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14806#issuecomment-1634678111


More information about the security-dev mailing list