RFR: 8311902: Concurrency regression in the PBKDF2 key impl of SunJCE provider [v2]

Sean Mullan mullan at openjdk.org
Tue Jul 18 16:36:12 UTC 2023


On Fri, 14 Jul 2023 21:57:32 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> This change adds back the Reference.ReachabilityFence(Object) call removed by [JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
>> 
>> Please help review.
>> Thanks!
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Include more methods into the scope for consistency/correctness sake.

Looks good. I think you should file a follow-on issue to make similar changes to DESKey, DESedeKey, PBEKey and other security classes that use Cleaner.

-------------

Marked as reviewed by mullan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14859#pullrequestreview-1535463205


More information about the security-dev mailing list