RFR: 8312259: StatusResponseManager unused code clean up [v2]

Xue-Lei Andrew Fan xuelei at openjdk.org
Wed Jul 19 04:05:49 UTC 2023


On Tue, 18 Jul 2023 21:54:07 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add final keyword back
>
> src/java.base/share/classes/sun/security/ssl/StatusResponseManager.java line 584:
> 
>> 582:     }
>> 583: 
>> 584:     static StaplingParameters processStapling(
> 
> Even though a static method is implicitly final, the final keyword does prevent subclasses from inadvertently using the same method signature.

Good point.  I got what you meant and will add the final keyword back.  Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14924#discussion_r1267511186


More information about the security-dev mailing list