RFR: 8307185: pkcs11 native libraries make JNI calls into java code while holding GC lock [v2]

[Daniel Jeliński]

> This patch fixes random deadlocks in PKCS11 decryption and encryption code.
> 
> The deadlocks were caused by object allocation in `ckAssertReturnValueOK` waiting for GC; GC was in turn waiting for `ReleasePrimitiveArrayCritical`, which never happened.
> 
> The fix moves the call to `ckAssertReturnValueOK` after `ReleasePrimitiveArrayCritical`.
> 
> All tests in sun/security/pkcs11 were executed with `JTREG=JAVA_OPTIONS=-Xcheck:jni` with and without this patch.
> Without this patch, 5 tests produced the following warning:
> 
> Warning: Calling other JNI functions in the scope of Get/ReleasePrimitiveArrayCritical or Get/ReleaseStringCritical
> 
> With this patch the warning was not observed.
> 
> Tier2-3 tests are still green.

Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:

  Remove redundant checks

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14931/files
  - new: https://git.openjdk.org/jdk/pull/14931/files/64f4894a..33e08bcf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14931&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14931&range=00-01

  Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/14931.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14931/head:pull/14931

PR: https://git.openjdk.org/jdk/pull/14931