RFR: JDK-8312512: sspi.cpp gss_export_name avoid delete on NULL fullname
Daniel Jeliński
djelinski at openjdk.org
Mon Jul 24 11:03:41 UTC 2023
On Mon, 24 Jul 2023 07:50:44 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> sspi.cpp contains the gss_export_name function, where at the end some cleanup is done by calling delete. However this should be done more careful, because the function get_full_name which is called in gss_export_name might return NULL, so we better avoid calling delete in this case.
`free`, `delete` and `delete[]` are all safe to call on a NULL pointer.
I noticed that we are checking for NULL in other places in this file; could you remove these checks?
-------------
Changes requested by djelinski (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14989#pullrequestreview-1543239479
More information about the security-dev
mailing list