RFR: JDK-8312512: sspi.cpp avoid some NULL checks related to free and delete [v2]

Matthias Baesken mbaesken at openjdk.org
Mon Jul 24 12:04:41 UTC 2023


On Mon, 24 Jul 2023 11:30:29 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> sspi.cpp contains the gss_export_name function, where at the end some cleanup is done by calling delete. However this should be done more careful, because the function get_full_name which is called in gss_export_name might return NULL, so we better avoid calling delete in this case.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove unneeded NULL checks forfree and delete calls

Hi Daniel , thanks for the review !
I adjusted the JBS issue short description text to better reflect what the change now does.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14989#issuecomment-1647775509


More information about the security-dev mailing list