RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v2]

Vyom Tewari vtewari at openjdk.org
Wed Jul 26 05:35:04 UTC 2023


On Tue, 25 Jul 2023 23:50:07 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Limit native memory allocation and move write loop from the native layer into Java. This change should make the OOME reported in the issue much less likely.
>
> Brian Burkhalter has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - 6478546: Decrease malloc limit to 1.5 MB
>  - 6478546: Minor refactoring
>  - 6478546: Prevent short read

src/java.base/share/native/libjava/io_util.c line 173:

> 171:         if (len > MAX_MALLOC_SIZE)
> 172:             len = MAX_MALLOC_SIZE;
> 173:         buf = (char*)malloc(len*sizeof(char));

please reformat line 173

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14981#discussion_r1274392919


More information about the security-dev mailing list