Withdrawn: 8312630: java/security should not create unmodifiable collections with redundant wrapping

John Jiang jjiang at openjdk.org
Wed Jul 26 23:38:51 UTC 2023


On Tue, 25 Jul 2023 06:27:25 GMT, John Jiang <jjiang at openjdk.org> wrote:

> Some java/security classes apply the below coding style,
> 
> Set<T> set = ...;
> Set<T> unmodifiableSet = Collections.unmodifiableSet(new HashSet<>(set));
> 
> It may be unnecessary to wrap that `set` with HashSet before creating `unmodifiableSet`.
> Some usages on `Collections.unmodifiableList` and `Collections.unmodifiableMap` have the same issue.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/15008


More information about the security-dev mailing list