RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v2]

Sergey Tsypanov stsypanov at openjdk.org
Thu Jul 27 13:45:54 UTC 2023


On Tue, 25 Jul 2023 23:50:07 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Limit native memory allocation and move write loop from the native layer into Java. This change should make the OOME reported in the issue much less likely.
>
> Brian Burkhalter has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - 6478546: Decrease malloc limit to 1.5 MB
>  - 6478546: Minor refactoring
>  - 6478546: Prevent short read

src/java.base/share/native/libjava/io_util.c line 199:

> 197:     }
> 198: 
> 199:     if (buf != stackBuf)

Wouldn't this cause a leak when if-condition is not met and `free(buf)` is not called?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14981#discussion_r1276302042


More information about the security-dev mailing list