RFR: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
Mark Powers
mpowers at openjdk.org
Fri Jul 28 16:51:41 UTC 2023
On Fri, 28 Jul 2023 15:34:47 GMT, Hai-May Chao <hchao at openjdk.org> wrote:
> JDK-8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java line 852:
> 850: Integer tmp = GetIntegerAction.privilegedGetProperty(
> 851: "jdk.jar.maxSignatureFileSize", 16000000);
> 852: if (tmp < 0 || tmp > MAX_ARRAY_SIZE) {
Can't `tmp` be `null`? After all, it is an `Integer` object. The rest of your code changes look fine to me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15072#discussion_r1277783838
More information about the security-dev
mailing list