RFR: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar [v3]

Hai-May Chao hchao at openjdk.org
Fri Jul 28 22:49:04 UTC 2023


On Fri, 28 Jul 2023 19:43:17 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   debug message update
>
> src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java line 857:
> 
>> 855:                         "is used as the specified size for the " +
>> 856:                         "jdk.jar.maxSignatureFileSize system property " +
>> 857:                         "is out of range: " + tmp);
> 
> The wording of the message is a bit hard to understand. I suggest rewording slightly as: 
> 
>                 debug.println("The default signature file size of 16000000 bytes " +
>                         "will be used as the specified size for the " +
>                         "jdk.jar.maxSignatureFileSize system property " +
>                         "since the value is out of range: " + tmp);

Reworded the debug message.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15072#discussion_r1278142837



More information about the security-dev mailing list