RFR: 8312259: StatusResponseManager unused code clean up [v3]
Mark Powers
mpowers at openjdk.org
Mon Jul 31 17:56:52 UTC 2023
On Wed, 19 Jul 2023 04:35:56 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:
>> Hi,
>>
>> May I have the code cleanup update reviewed? With this update, the unused code in StatusResponseManager.java will be removed.
>>
>> Thanks,
>> Xuelei
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>
> revise test case
I'm not sure I would have gone to the trouble to remove methods used by tests, but I understand your motivation. StatusResponseManager is definitely improved.
test/jdk/sun/security/ssl/Stapling/java.base/sun/security/ssl/StatusResponseManagerTests.java line 105:
> 103: }
> 104:
> 105:
Nit: added space
-------------
Marked as reviewed by mpowers (Author).
PR Review: https://git.openjdk.org/jdk/pull/14924#pullrequestreview-1555445177
PR Review Comment: https://git.openjdk.org/jdk/pull/14924#discussion_r1279679556
More information about the security-dev
mailing list