RFR: 8308711: Develop additional Tests for KEM implementation [v4]

[Weijun Wang]

On Thu, 1 Jun 2023 07:37:38 GMT, Sibabrata Sahoo <ssahoo at openjdk.org> wrote:

>> Additional Tests for KEM API.
>
> Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Comments addressed

test/jdk/javax/crypto/KEM/GenLargeNumberOfKeys.java line 79:

> 77:                 sk.getEncoded()));
> 78:         Asserts.assertTrue(Arrays.equals(d.decapsulate(enc.encapsulation()).getEncoded(),
> 79:                 enc.key().getEncoded()));

Do you really mean to test this 3 times? If so, add a comment.

test/jdk/javax/crypto/KEM/KemTest.java line 138:

> 136:                         decT.decapsulate(enc.encapsulation()).getEncoded().length);
> 137:                 Asserts.assertEQ(decT.decapsulate(enc.encapsulation()).getEncoded().length,
> 138:                         enc.key().getEncoded().length);

Try adding a test on the `encapsulationSize()` method on the decapsulator.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14113#discussion_r1213229215
PR Review Comment: https://git.openjdk.org/jdk/pull/14113#discussion_r1213232120