RFR: 8308711: Develop additional Tests for KEM implementation [v4]
Weijun Wang
weijun at openjdk.org
Thu Jun 1 14:51:15 UTC 2023
On Thu, 1 Jun 2023 14:44:53 GMT, Sibabrata Sahoo <ssahoo at openjdk.org> wrote:
>> test/jdk/javax/crypto/KEM/KemTest.java line 138:
>>
>>> 136: decT.decapsulate(enc.encapsulation()).getEncoded().length);
>>> 137: Asserts.assertEQ(decT.decapsulate(enc.encapsulation()).getEncoded().length,
>>> 138: enc.key().getEncoded().length);
>>
>> Try adding a test on the `encapsulationSize()` method on the decapsulator.
>
> It is there L-130,131, Do you want any specific case?
> Asserts.assertEQ(encT.encapsulationSize(), enc.encapsulation().length);
> Asserts.assertEQ(encT.encapsulationSize(), decT.encapsulationSize());
Oh sorry, I just looked at the left side of `assertEQ`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14113#discussion_r1213273898
More information about the security-dev
mailing list