RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v14]

[Cesar Soares Lucas]

On Mon, 5 Jun 2023 05:10:13 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Catching up with master branch.
>>    
>>    Merge remote-tracking branch 'origin/master' into rematerialization-of-merges
>>  - Address PR review 6: refactoring around rematerialization & improve test cases.
>>  - Address PR review 5: refactor on rematerialization & add tests.
>>  - Merge remote-tracking branch 'origin/master' into rematerialization-of-merges
>>  - Address part of PR review 4 & fix a bug setting only_candidate
>>  - Catching up with master
>>    
>>    Merge remote-tracking branch 'origin/master' into rematerialization-of-merges
>>  - Fix tests. Remember previous reducible Phis.
>>  - Address PR review 3. Some comments and be able to abort compilation.
>>  - Merge with Master
>>  - Addressing PR review 2: refactor & reuse MacroExpand::scalar_replacement method.
>>  - ... and 5 more: https://git.openjdk.org/jdk/compare/46c4da7f...8f81a7c8
>
> src/hotspot/share/opto/compile.cpp line 2332:
> 
>> 2330:       }
>> 2331: 
>> 2332:       NOT_PRODUCT(ConnectionGraph::verify_ram_nodes(this, root());)
> 
> Why do you limit the check to non-product builds only? It won't fail the compilation with product builds.

Duh. I'll fix that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12897#discussion_r1218525026