RFR: 8301553: Support Password-Based Cryptography in SunPKCS11 [v6]

[Martin Balao]

On Mon, 5 Jun 2023 23:17:02 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Martin Balao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #4)
>>   
>>   Co-authored-by: Francisco Ferrari <fferrari at redhat.com>
>>   Co-authored-by: Martin Balao <mbalao at redhat.com>
>
> test/jdk/sun/security/pkcs11/PKCS11Test.java line 870:
> 
>> 868:             @Override
>> 869:             public byte[] getEncoded() {
>> 870:                 return new byte[0];
> 
> Well, instead of returning a 0-length byte array, how about throwing a RuntimeException indicating this method is not meant to be called? This would help troubleshooting if needed.

Sounds good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12396#discussion_r1218853753