RFR: 8281658: Add a security category to the java -XshowSettings option [v2]

[Sean Coffey]

On Tue, 13 Jun 2023 14:30:57 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8281658-showsettings-security
>>  - Incorporate feedback to date
>>  - minor edits, copyright, descriptions etc
>>  - Merge branch 'master' into 8281658-showsettings-security
>>  - Merge branch 'master' into 8281658-showsettings-security
>>  - 8281658
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 189:
> 
>> 187:                 } else {
>> 188:                     printSecuritySettings("all");
>> 189:                 }
> 
> Perhaps a slight preference for:
> 
>             var opt = opts.length > 2 ? opts[2].trim() : "all";
>             printSecuritySettings(opt);

fair point. done

> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 422:
> 
>> 420:             ostream.println(TWOINDENT + "Provider name: " + p.getName());
>> 421:             if (verbose) {
>> 422:                 ostream.println(TWOINDENT + PROV_INFO_STRING + wrappedString(p.getInfo(), 80));
> 
> Wrapping the args at 80 might still produce line that is quite long.
> Perhaps wrap the string after it was concatenated.

logic updated. I think that's what you were hinting at Roger.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1229446518
PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1229447236