RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

Sean Mullan mullan at openjdk.org
Wed Jun 14 14:10:05 UTC 2023


On Wed, 14 Jun 2023 11:52:35 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Sean Coffey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Incorporate review comments from Roger and tweak some code
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 424:
> 
>> 422:                if (!services.isEmpty()) {
>> 423:                    services.stream()
>> 424:                            .sorted(Comparator.comparing(Provider.Service::getType))
> 
> How about sorting by algorithm within the same type?
> 
> Another suggestion: adding aliases to output, for example: `Signature: Ed25519 (1.3.101.112, OID.1.3.101.112)`.

+1 to sorting by algorithm name within same type.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1229680104



More information about the security-dev mailing list