RFR: 8281658: Add a security category to the java -XshowSettings option [v3]

Alan Bateman alanb at openjdk.org
Thu Jun 15 06:35:01 UTC 2023


On Thu, 15 Jun 2023 06:29:09 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Sean Coffey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Incorporate review comments from Roger and tweak some code
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 183:
> 
>> 181:             case "locale":
>> 182:                 printLocale();
>> 183:                 break;
> 
> printLocale might need the same treatment to avoid printing the list of all locales by default.

Have you tried putting the new code into say sun.launcher.SecuritySettings to avoid adding so much security conf code into LauncherHelper? Maybe eventually this will need to a more pluggable as -XshowSettings has grown a bit beyond what it was originally for.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1230499915



More information about the security-dev mailing list