RFR: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers

Bradford Wetmore wetmore at openjdk.org
Fri Jun 16 02:56:14 UTC 2023


On Thu, 15 Jun 2023 06:02:13 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which fixes the issue noted in https://bugs.openjdk.org/browse/JDK-8310106?
> 
> The commit here fixes the typo in `sun.security.ssl.SSLHandshake.getHandshakeProducer()` method to correctly use `handshakeProducers`.
> 
> I checked if a new jtreg test could be added for this, but given where this change resides and the nature of this change, I don't see a way to add one. Existing tests in `tier1`, `tier2` and `tier3` continue to pass with this change.

LGTM.  

I think I understand why we never saw any impact.  

Tagging @XueleiFan in case he wants to also review it, but this looks pretty straightforward.

-------------

Marked as reviewed by wetmore (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14483#pullrequestreview-1482643233



More information about the security-dev mailing list