RFR: 8309667: TLS handshake fails because of ConcurrentModificationException in PKCS12KeyStore.engineGetEntry [v3]

[Weijun Wang]

On Fri, 16 Jun 2023 09:53:10 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more cases to cover
>
> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 1:
> 
>> 1: /*
> 
> Please modify the `entry.attributes` initializers in lines 240, 700 and 2519 as well. I suppose you could also make the `attributes` final and initialize in line.

Thanks. I'll keep the structure as it is now.

> src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java line 2434:
> 
>> 2432:             String alias = null;
>> 2433:             byte[] keyId = null;
>> 2434:             ObjectIdentifier[] trustedKeyUsage = null;
> 
> This change is not necessary; this set is never used by other threads.

Correct.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14506#discussion_r1232203289
PR Review Comment: https://git.openjdk.org/jdk/pull/14506#discussion_r1232203002