RFR: 8290005: com/sun/jndi/ldap/LdapCBPropertiesTest.java failling with NullPointerException [v2]

Matthew Donovan mdonovan at openjdk.org
Wed Jun 21 12:09:33 UTC 2023


On Fri, 16 Jun 2023 14:58:06 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:

>> Yes, socket close is a headache problem for me.
>
> There's a bit of a history with SSLSocket closures since the new handshaker was brought into JDK11.  Some of it dealt with synchronization, others with properly handling full vs. half-duplex closes.  You may want to look up some of the bug history on changes surrounding the SSLSocket closures just to make sure we don't undo any fixes that were previously integrated.  As Xuelei's comment indicates, this is a delicate part of the handshaker.

I reverted the changes to SSLEngineImpl and looked at the history of SSLSocketImpl and TransportContext but didn't see anything that I would be undoing with this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13742#discussion_r1236889784



More information about the security-dev mailing list