RFR: 8279254: PKCS9Attribute SigningTime always encoded in UTFTime [v4]

Jamil Nimeh jnimeh at openjdk.org
Fri Jun 23 15:26:05 UTC 2023


On Fri, 23 Jun 2023 15:20:24 GMT, Ben Perez <duke at openjdk.org> wrote:

>> Added single-argument `putTime` method to `DerOutputStream` that selects the correct encoding based on the `Date` value. Similarly, a `getTime` method was added to `DerValue` to automatically call the correct decoding function based on the date type specified by the `tag`. Furthermore, the `encode` method in `PKCS9Attribute` was changed to utilize the new `putTime` method.
>
> Ben Perez has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved UTC date range to constants

Looks good to me.

-------------

Marked as reviewed by jnimeh (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14617#pullrequestreview-1495360483



More information about the security-dev mailing list