RFR: JDK-8308398 Move SunEC crypto provider into java.base [v2]

Anthony Scarpino ascarpino at openjdk.org
Thu Jun 29 19:58:56 UTC 2023


On Thu, 29 Jun 2023 18:36:55 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update for review:  changed test, removed commented out code in module, fixed switch statement, added --limit-modules
>
> src/java.base/share/classes/sun/security/jca/ProviderConfig.java line 235:
> 
>> 233:             provider = p;
>> 234:         }
>> 235:         return provider;
> 
> Why changing it to return 'provider', is this change intentional? IIRC, the general pattern is to return the local reference instead of a volatile variable.

Ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14457#discussion_r1247106719



More information about the security-dev mailing list