RFR: JDK-8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return [v2]

Matthias Baesken mbaesken at openjdk.org
Thu Mar 2 09:47:56 UTC 2023


> We have a (potential) early return in addCertificatesToKeystore in KeystoreImpl.m . This is implemented by the CHECK_NULL macro. However this missed a CFRelease call.

Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:

  handle missing CFRelease calls

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12788/files
  - new: https://git.openjdk.org/jdk/pull/12788/files/5508cdba..7f5c63f5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12788&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12788&range=00-01

  Stats: 19 lines in 1 file changed: 14 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/12788.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12788/head:pull/12788

PR: https://git.openjdk.org/jdk/pull/12788



More information about the security-dev mailing list