RFR: JDK-8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return [v3]

Matthias Baesken mbaesken at openjdk.org
Wed Mar 8 08:58:07 UTC 2023


> Similar to what had been done in [JDK-8303354](https://bugs.openjdk.org/browse/JDK-8303354) , we miss CFRelease on the variable identitySearch in early CHECK_NULL returns potentially done in the function addIdentitiesToKeystore.

Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:

  Fix if check

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12905/files
  - new: https://git.openjdk.org/jdk/pull/12905/files/0718db2b..74b69104

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12905&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12905&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/12905.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12905/head:pull/12905

PR: https://git.openjdk.org/jdk/pull/12905


More information about the security-dev mailing list