RFR: 8303764: sunmscapi.dll cannot compile under permissive-

[Daniel Jeliński]

The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.

----------------------------------------------------------------------
On Tue, 7 Mar 2023 17:27:56 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> security.cpp contains a few invalid implicit conversions between pointer types that will not fly when the permissive- compiler option is active. Given that permissive- will become the Visual C++ compiler's default mode of operation in the future, it is better to handle this now so future compiler upgrades will not cause issues. Problems here are very easily solved with explicit casts

When `-Zc:wchar_t-` flag is added, `wchar_t` is equivalent to `jchar`; it's the default in C, which probably explains why this was the only failure. It allows us to avoid many reinterpret_casts, which are the root of all evil.

I guess we could explore changing jchar's typedef to wchar_t on Windows; we can't do that on other systems, because wchar_t is 32 bit there.

-------------

PR: https://git.openjdk.org/jdk/pull/12907