RFR: 8303764: Turn off -Zc:wchar_t- for Visual C++ [v3]

[Julian Waters]

The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.

----------------------------------------------------------------------
On Thu, 9 Mar 2023 12:00:55 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into patch-7
>>  - -Zc:wchar_t should be enabled
>>  - Remove explicit wchar_t check in jdk.accessibility
>>  - sunmscapi.dll cannot compile under permissive-
>
> src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp line 544:
> 
>> 542:                 {
>> 543:                     if ((dwKeySpec & CERT_NCRYPT_KEY_SPEC) == CERT_NCRYPT_KEY_SPEC) {
>> 544:                         PP("CNG %lld", (long long) hCryptProv);
> 
> What error were you seeing here before your changes?

Oh, that one wasn't really an error, but given that Microsoft has changed their definitions of a 64 bit int to a long long and the I64 specifier to ll in the ucrt for quite some time now, I figured that this was some extra cleanup I could fit in here. Not strictly required, but convenient code cleanliness for good measure nonetheless

-------------

PR: https://git.openjdk.org/jdk/pull/12907