RFR: 8302017: Allocate BadPaddingException only if it will be thrown

Wed Mar 15 15:10:27 UTC 2023

On Thu, 23 Feb 2023 18:15:35 GMT, Ahmed Muhsin <duke at openjdk.org> wrote:

> This change will move the instantiation of BadPaddingException into the branch of the if statement where it is thrown. This will decrease the overhead of calling `unpadV15` and `unpadOAEP`.  Please see the associated work item for past discussions regarding this change.
> 
> The build and tier1 tests pass locally on mac-aarch64.

Well `throw` will always be slower than `return`, even if the stack trace is populated on both paths. How do we know if we are not vulnerable to Bleichenbacher's attack today?
(granted, creating the exception on `throw` path only will increase the timing difference)

-------------

PR: https://git.openjdk.org/jdk/pull/12732