RFR: 8302017: Allocate BadPaddingException only if it will be thrown

Cesar Soares Lucas cslucas at openjdk.org
Wed Mar 15 18:11:28 UTC 2023


On Thu, 23 Feb 2023 18:15:35 GMT, Ahmed Muhsin <duke at openjdk.org> wrote:

> This change will move the instantiation of BadPaddingException into the branch of the if statement where it is thrown. This will decrease the overhead of calling `unpadV15` and `unpadOAEP`.  Please see the associated work item for past discussions regarding this change.
> 
> The build and tier1 tests pass locally on mac-aarch64.

I may be wrong here but my take on this is that there is nothing at the language level that prevents the compiler from optimizing the code and moving the allocation inside the "If". In fact, GRAAL might as well be doing this as part of Partial Escape Analysis.

-------------

PR: https://git.openjdk.org/jdk/pull/12732


More information about the security-dev mailing list