RFR: 8301553: Support Password-Based Cryptography in SunPKCS11

[Martin Balao]

On Fri, 17 Mar 2023 15:47:41 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/util/PBEUtil.java line 59:
>> 
>>> 57:         }
>>> 58: 
>>> 59:         public AlgorithmParameters getAlgorithmParameters(int blkSize,
>> 
>> I see most if not all of the methods in this class are lifted from other classes as the result of code refactoring. Would be nice to document its callers, e.g. where it's used.
>
> I added references, that include the security provider and class, to each method and inner class in PBEUtil. The instance methods in PBEUtil$PBES2Params use the reference for their containing class. Let me know if you still want to repeat the reference for each one.

We finally decided to include a general comment in the PBEUtil$PBES2Params class and also comments in each method. We also added comments to other PBEUtil methods.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12396#discussion_r1142937134