RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v4]

Vladimir Kozlov kvn at openjdk.org
Fri Mar 24 23:40:31 UTC 2023


On Fri, 24 Mar 2023 23:24:47 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> src/hotspot/share/opto/macro.hpp line 196:
>> 
>>> 194:                           Node* size_in_bytes);
>>> 195: 
>>> 196:   static Node* make_arraycopy_load(Compile* comp, PhaseIterGVN* igvn, ArrayCopyNode* ac, intptr_t offset, Node* ctl, Node* mem, BasicType ft, const Type *ftype, AllocateNode *alloc);
>> 
>> Why you need this change? It polluted diffs and hide important changes. Could be separate change from this one.
>
> I had to make this method static because it uses `value_from_mem` - which I also made static. I had to make `value_from_mem` static so that I can use it outside PhaseMacroExpand.

I see, you use it in escape.cpp. Okay. I need to review changes there too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12897#discussion_r1148144963


More information about the security-dev mailing list