RFR: 8302819: Remove JAR Index

[Eirik Bjorsnos]

On Thu, 23 Mar 2023 14:09:32 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Perhaps now is the time to add a deprecation/warning message when `jar -i` option is used?

I'm not entirely sure I know what you mean or suggest here, so I'll try to be explicit with what I do (think I) understand and what my reasoning is:

I one of my early comments on JDK-8302819, I suggest / recommend that the deprecation and/or eventual removal of the `jar -i` options is handled as a follow-up to this PR. My reasoning was the usual concerns about PRs: Reducing the scope seems to make the review process simpler, faster, more efficient.

Hooking in a simple deprecation warning  in this PR would propably not require a lot of extra review cycles, perhaps the opposite. So I'm happy to do that if that is what you meant and Alan also agrees.

Do you think I understood your comment?

> Sorry my previous message wasn't clear.

Thanks for clarifying, Jaikiran. I think our understanding is in sync now, which is always good!

@jaikiran Do you agree with the move of `JarIndex` from `java.base` to `jdk.jartool`? Since it ends up only being used there, I thought it would be cleaner if we moved it. But the move is not strictly necessary. What's your thoughts?

> Like you, I too would let Alan provide guidance on whether this should be done as part of this PR.

The alternative to including it in this PR would be to do it immediately following the integration of this PR. For users it maybe does not matter much as long as two changes are included in the same JDK/Java SE version?

> Adding these tests I think will help us verify that these APIs and also exercise the code in these classes where we have checks for `META-INF/INDEX.LIST` entry. Is that something you could consider adding as part of this PR?

Yes, I agree this should be done. For now, I've added a note in the "Outstanding code work" section at the top of this PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13158#issuecomment-1481293806
PR Comment: https://git.openjdk.org/jdk/pull/13158#issuecomment-1481309871
PR Comment: https://git.openjdk.org/jdk/pull/13158#issuecomment-1481321377
PR Comment: https://git.openjdk.org/jdk/pull/13158#issuecomment-1481348568
PR Comment: https://git.openjdk.org/jdk/pull/13158#issuecomment-1485529082