RFR: 8302819: Remove JAR Index [v2]

Eirik Bjorsnos duke at openjdk.org
Wed Mar 29 19:55:40 UTC 2023


On Tue, 28 Mar 2023 20:06:03 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Eirik Bjorsnos has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Remove blank line 93 as per suggestion by Mandy
>>  - Merge branch 'master' into remove-jar-index
>>  - Remove JarIndex default constructor
>>  - Make JarIndex.INDEX_NAME package private
>>  - Remove outdated reference to URLClassLoader using JarIndex
>>  - Make JarIndex package private
>>  - The JarIndex.merge method ended up being used only by the JarIndexMergeTest test. Removing this test, the JarIndex.merge methods and a number of other JarIndex methods not used by the 'jar' tool
>>  - Revert the export of sun.security.action to jdk.jartool. JarIndex can use System.property instead since the 'jar' tool does not run with a SecurityManager
>>  - Revert noisy whitespace changes
>>  - Revert noisy whitespace changes
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/599939df...2b5d8a4a
>
> src/java.base/share/classes/jdk/internal/loader/URLClassPath.java line 936:
> 
>> 934:         @Override
>> 935:         URL[] getClassPath() throws IOException {
>> 936: 
> 
> Nit: extra line 936 can be removed.

Thank to @mlchung,  line 936 is now history!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13158#discussion_r1152412960



More information about the security-dev mailing list