RFR: 8298127: HSS/LMS Signature Verification [v3]

Ferenc Rakoczi duke at openjdk.org
Tue May 2 20:39:23 UTC 2023


On Thu, 27 Apr 2023 17:39:14 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   addressing more review comments
>
> src/java.base/share/classes/sun/security/provider/HSS.java line 66:
> 
>> 64:         if (!(publicKey instanceof HSSPublicKey pub)) {
>> 65:             throw new InvalidKeyException("Not an HSS public key: ");
>> 66:         }
> 
> If not, we can try translating it using our `KeyFactory`.

Done

> src/java.base/share/classes/sun/security/provider/HSS.java line 758:
> 
>> 756:             if (key instanceof HSSPublicKey) {
>> 757:                 return key;
>> 758:             }
> 
> We need to be able to translate other HSS/LMS public keys into our own type as long as the algorithm and format are OK.
> 
> You can try this out by duplicating your implementation with a different provider name in a different package.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1183022892
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1183023531



More information about the security-dev mailing list