RFR: 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts

[Weijun Wang]

On Tue, 2 May 2023 23:20:20 GMT, Jamil Nimeh <jnimeh at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/action/GetPropertyAction.java line 192:
>> 
>>> 190: 
>>> 191:         // Determine if "ms" is on the end of the string
>>> 192:         boolean isMillis = propVal.toLowerCase().endsWith("ms");
>> 
>> Shall we allow the `s` suffix as well? This makes it clear that a value is in seconds.
>
> Well, all the existing documentation already states that they are in seconds.  That was why I didn't add any additional suffixes.  The goal was to make it so folks don't need to make any changes if the existing seconds-level granularity is sufficient for them.

I don't mean not to support bare numbers. It's just a little unfair that millisecond has a suffix but second does not. We can support all of "1", "1s", and "1000ms".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13762#discussion_r1183156016