RFR: 8297878: KEM: Implementation [v12]

Sibabrata Sahoo ssahoo at openjdk.org
Wed May 3 09:43:40 UTC 2023


On Thu, 27 Apr 2023 15:40:53 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> The KEM API and DHKEM impl. Note that this PR uses new methods in https://github.com/openjdk/jdk/pull/13250.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   more @since and about nulls

test/jdk/com/sun/crypto/provider/DHKEM/Compliance.java line 97:

> 95:         // Cannot detect invalid params before provider selection
> 96: //        Utils.runAndCheckException(
> 97: //                () -> KEM.getInstance("DHKEM", new KEMParameterSpec() {}),

Commented code block can be removed. Signature of getInstance() doesn't exist.

test/jdk/com/sun/crypto/provider/DHKEM/Compliance.java line 112:

> 110:                 ExChecker.of(InvalidKeyException.class).by(DHKEM.class));
> 111: 
> 112:         // Not an EC key at all, rejected by framework coz SupportedClasses

Do you mean UnsupportedClasses in comment section?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1183247590
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1183269537



More information about the security-dev mailing list