RFR: 8294983: SSLEngine throws ClassCastException during handshake [v3]

Thu May 4 00:21:17 UTC 2023

On Wed, 3 May 2023 20:51:30 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> Fixes a scenario where a `ServerHandshakeContext` might be cast as a `ClientHandshakeContext`.
>
> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - address code review comment
>  - updated copyright
>  - set consumer to null if we're not in client mode

Other than the comment suggestion, LGTM.  

Putting comment in the bug as Mark suggested requires archeology, thus I suggest it be directly in the codebase.  I'm a huge proponent of comments when things aren't always obvious.

-------------

Marked as reviewed by wetmore (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13727#pullrequestreview-1412071577