RFR: 8298127: HSS/LMS Signature Verification [v5]

Weijun Wang weijun at openjdk.org
Mon May 8 16:19:42 UTC 2023


On Mon, 8 May 2023 15:22:07 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Yes, I think so. If someone wants to test with several different keys by first creating RawKeySpec objects from an array in which a few bytes are changed between the calls and and then use these KeySpecs to create the actual keys, without the cloning they will end up with the same keys. So an immutable object is better.
>
> Ok. Try to keep your line lengths to about 80 chars.

I think so too. This class is only used by tests now so it will not have any negative performance impact on real users. If we want to move it into the public one day then we don't need to update it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1187631611



More information about the security-dev mailing list