RFR: 8298127: HSS/LMS Signature Verification [v7]

Mark Powers mpowers at openjdk.org
Mon May 8 20:16:44 UTC 2023


On Mon, 8 May 2023 16:24:27 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressing more review comments from @wangweij and @seanjmullan
>
> src/java.base/share/classes/sun/security/provider/HSS.java line 240:
> 
>> 238:         public final static int LMS_SHA256_M32_H20 = 8;
>> 239:         public final static int LMS_SHA256_M32_H25 = 9;
>> 240:         public final static int LMS_SHA256_M24_H5 = 10;
> 
> Shall we remove the SHA256_M24 and SHAKE constants at the moment?

I think unused code is a distraction. That said, SHA256_M24 used to work. Can't we be better than BC and support M24?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1187853903


More information about the security-dev mailing list