RFR: 8298127: HSS/LMS Signature Verification [v8]

Weijun Wang weijun at openjdk.org
Tue May 9 14:40:40 UTC 2023


On Tue, 9 May 2023 12:45:27 GMT, Ferenc Rakoczi <duke at openjdk.org> wrote:

>> Implement support for Leighton-Micali Signatures (LMS) as described in RFC 8554. LMS is an approved software signing algorithm for CNSA 2.0, with SHA-256/192 parameters recommended.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   agreeing with the newest review comments

src/java.base/share/classes/sun/security/provider/HSS.java line 47:

> 45: 
> 46:     @Deprecated
> 47:     protected void engineSetParameter(String param, Object value) {

Better to add `@Override` as much as you can.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1188709964



More information about the security-dev mailing list