RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v6]

Fri May 12 20:32:50 UTC 2023

On Fri, 12 May 2023 20:14:56 GMT, Sean Mullan <mullan at openjdk.org> wrote:

> Do you have any plans to write a test? If not, the bug needs a `noreg` label.

As discussed internally, the test that surfaced this issue will be incorporated into regular testing.

> src/java.base/share/classes/sun/security/ssl/CertificateAuthoritiesExtension.java line 136:
> 
>> 134:             } catch (IllegalArgumentException iae) {
>> 135:                 throw new SSLException("X500Principal could not be parsed " +
>> 136:                         "successfully", iae);
> 
> Is it ok to throw a general `SSLException` here? Or do you need to call `TransportContext.fatal()` so that additional cleanup happens? Perhaps @XueleiFan would know.

Yes, let's wait for @XueleiFan

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13466#issuecomment-1546257007
PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1192769497